Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add Danish localization #2041

Merged
merged 3 commits into from
Jan 31, 2024
Merged

feat: add Danish localization #2041

merged 3 commits into from
Jan 31, 2024

Conversation

ddfreiling
Copy link
Contributor

@ddfreiling ddfreiling commented Nov 30, 2023 •
edited
Loading

This localization was made in my capacity as CTO of https://nota.dk - The Danish national library for people with reading disabilities.

@MyGulstad can you proofread this?

@socket-security Socket Security
Copy link

New dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
@vanilla-extract/babel-plugin 1.2.0 environment +0 55.8 kB seek-oss-ci

@panaC
Copy link
Member

panaC commented Nov 30, 2023

Many thanks !

MyGulstad
MyGulstad reviewed Dec 1, 2023
View reviewed changes
Copy link

@MyGulstad MyGulstad left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comments in Danish:

Overvejede om der skulle bindestreg i "LCP licensen". Det er ok uden, tænker jeg.

Jeg har ensrettet imperativ til IKKE at bruge accent "é". Mod hvad vi plejer. Læser at Dansk Sprognævn anbefaler man begrænser brugen læser jeg dette som - jf. https://dsn.dk/ordboeger/retskrivningsordbogen/%C2%A7-1-6-bogstaver-og-tegn/%C2%A7-5-accenttegn-accent-aigu/
Jeg kan godt leve med 'aktivér' og 'importér', hvis du hælder mest til det.

For at skelne mellem 'available' og 'accessible' kan vi bruge hhv. 'til rådighed' og 'tilgængelig'. Kan evt. også skrive 'kan lånes / købes' men den kan måske også lejes, så hælder mest til 'til rådighed' :)

src/resources/locales/da.json Outdated
"noPublicationHelpL1": "Træk en bog hertil",
"noPublicationHelpL2": "eller brug \"+\" knappen ovenfor.",
"noPublicationHelpL3": "LCP beskyttede filer understøttes.",
"noPublicationHelpL4": "Understøttede udviddelser:",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Understøttede udvidelser:",

src/resources/locales/da.json Outdated
"info": {
"availableSince": "Siden",
"availableState": {
"available": "Tilgængelig",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Til rådighed",

src/resources/locales/da.json Outdated
"available": "Tilgængelig",
"ready": "Klar",
"reserved": "Reserveret",
"unavailable": "Utilgængelig",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Ikke til rådighed",

src/resources/locales/da.json Outdated
"accessibility": {
"bookMenu": "Menu",
"closeDialog": "Luk",
"importFile": "Importér en bog",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Importer en bog",

src/resources/locales/da.json Outdated
"import": "Bekræft at du vil importere disse filer:",
"importError": "der skete en fejl, tjek at filernes type er en af ({{acceptedExtension}})",
"renew": "Bekræft at du ønsker at forlænge licensen til denne bog",
"return": "Bekræft at du ønsker at aflevere dene bog tilbage",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Bekræft at du ønsker at aflevere denne bog",

src/resources/locales/da.json Outdated
"publicationNoToc": "denne bog har ingen indholdsfortegnelse"
},
"tts": {
"activate": "Aktivér TTS",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Aktiver TTS",

src/resources/locales/da.json Outdated
"button": "Mere information",
"title": "Om {{- appName}}"
},
"addBookToLib": "Importér",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Importer",

src/resources/locales/da.json Outdated
"unknown": "Ukendt"
},
"availableUntil": "Indtil",
"copyAvalaible": "Tilgængelig",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Til rådighed",

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

eller
"Kan lånes / købes",

src/resources/locales/da.json Outdated
"publisher": "Udgiver",
"readBook": "Læs bog",
"released": "Udgivelsesdato",
"sort": "Sortér efter",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Sorter efter",

src/resources/locales/da.json Outdated
"300pct": "300 %",
"500pct": "500 %",
"50pct": "50 %",
"fit": "sidebredde",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"tilpas side",

@ddfreiling
Copy link
Contributor Author

ddfreiling commented Dec 1, 2023 •
edited
Loading

@MyGulstad Thanks for the proofreading, som good catches 😄
I personally prefer the Importér form, but I think for simplicity's sake we'll remove all the é usage.

@panaC Should be ready for merge now.

@ddfreiling
Copy link
Contributor Author

ddfreiling commented Dec 15, 2023 •
edited
Loading

@panaC What is the procedure for getting new localisations merged?

@danielweck
Copy link
Member

@ddfreiling I will merge this PR after a few validation steps.

@danielweck danielweck changed the base branch from develop to l10n/danish January 31, 2024 18:25
@danielweck danielweck merged commit 87fc00c into edrlab:l10n/danish Jan 31, 2024
@danielweck danielweck mentioned this pull request Jan 31, 2024
Merged
@danielweck
Copy link
Member

New PR to add some plumbing and perform additional checks before merging: #2064

danielweck added a commit that referenced this pull request Jan 31, 2024
@danielweck
feat(l10n): Danish localization (PR #2064 original PR #2041)
5955c66
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MyGulstad MyGulstad MyGulstad left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ddfreiling @panaC @danielweck @MyGulstad