Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update removing priority from nelp koa #801

Closed

Conversation

johanseto
Copy link
Contributor

@johanseto johanseto commented Jan 19, 2024

Description

Migration PR to Nelp

Remove priority from static main tabs to make tab sorting function works correctly

(cherry picked from commit 2ca69ec19b3227e9efbe7481e0abe3ff44c8f11c) (cherry picked from commit c4d5411)

Testing instructions

Having the following pages config in studio.
Screenshot from 2024-01-19 16-26-41

Check the order of the tabs.

Before

before-pages

After

2024-01-19_16-26

Remove priority from static main tabs to make tab sorting function works correctly

(cherry picked from commit 2ca69ec19b3227e9efbe7481e0abe3ff44c8f11c)
(cherry picked from commit c4d5411)
@johanseto
Copy link
Contributor Author

Closed in favour of nelc/edx-platform#2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants