-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: create a new setting USE_DISCUSSIONS_MFE #809
feat: create a new setting USE_DISCUSSIONS_MFE #809
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Additionally, before approving the PR, I would like to see the changes in amberes first because, according to my experience, there may be different settings that can change the way the code is executed, and it would be great to ensure the proper functioning
Co-authored-by: Brayan Cerón <86393372+bra-i-am@users.noreply.github.com>
3b2f939
to
877ba07
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've been testing the MFE in the amberes environment and I don't know if it is even a problem, but when the flag is turned from true
to false
, the MFE lasts some minutes being disabled; despite the time it takes, everything works as expected.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me. I only have one suggestion: change the variable name USE_DISCUSSIONS_MFE_FRONTEND in the PR name or when you squash the commit because it is not consistent with the code.
Remember to add the documentation about how to enable or disable this here: https://docs.google.com/document/d/1j_kyDTdDaS1jnXgK0zbJOdz1XJja5lXvBzye8dmUhYA/edit?usp=sharing
fe07703
into
ednx-release/palma.master
Thanks!! |
* feat: create a new setting USE_DISCUSSIONS_MFE * feat: add new setting USE_DISCUSSIONS_MFE * fix: quality checks * fix: add setting override * fix: add setting override * fix: add setting override * fix: pep 8 violations * fix: update setting name Co-authored-by: Brayan Cerón <86393372+bra-i-am@users.noreply.github.com> * fix: change variable name --------- Co-authored-by: Brayan Cerón <86393372+bra-i-am@users.noreply.github.com>
* feat: create a new setting USE_DISCUSSIONS_MFE * feat: add new setting USE_DISCUSSIONS_MFE * fix: quality checks * fix: add setting override * fix: add setting override * fix: add setting override * fix: pep 8 violations * fix: update setting name Co-authored-by: Brayan Cerón <86393372+bra-i-am@users.noreply.github.com> * fix: change variable name --------- Co-authored-by: Brayan Cerón <86393372+bra-i-am@users.noreply.github.com>
* feat: create a new setting USE_DISCUSSIONS_MFE * feat: add new setting USE_DISCUSSIONS_MFE * fix: quality checks * fix: add setting override * fix: add setting override * fix: add setting override * fix: pep 8 violations * fix: update setting name Co-authored-by: Brayan Cerón <86393372+bra-i-am@users.noreply.github.com> * fix: change variable name --------- Co-authored-by: Brayan Cerón <86393372+bra-i-am@users.noreply.github.com>
Description
This PR adds a new setting
USE_DISCUSSIONS_MFE
that will allow Discussions MFE to be enabled or disabled in the tenantSupporting information
JIRA Issue DS-806
Testing instructions
tutor plugins install mfe
, and enable ittutor plugins enable mfe
tutor plugins install forum
tutor config save
tutor dev launch
tutor dev exec lms/cms bash
, install eox-tenantpip install eox-tenant
, and run the migrations./manage.py lms makemigrations
and./manage.py lms migrate
tutor dev restart
site1
and the other one with the organizationsite2