Jlc/nid pipeline #106
Merged
Jlc/nid pipeline #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johanseto
force-pushed
the
jlc/nid-pipeline
branch
from
41ce7ed to
8601037
Compare
andrey-canon
requested changes
Nov 14, 2023
| dict: Dict with user if matches, if not return None. | ||
| """ | ||
| if user: | ||
| return None |
There was a problem hiding this comment.
this should always return a dict, in this case that should be an empty dict since the pipeline logic will check the kind of instance
There was a problem hiding this comment.
I was thinking about this and why other pipes work using None in the return.
https://github.com/eduNEXT/eox-tenant/blob/master/eox_tenant/pipeline.py#L25
https://github.com/python-social-auth/social-core/blob/master/social_core/pipeline/social_auth.py#L67
Then I found that there is an or-line that allow use None changing it to {}.
There was a problem hiding this comment.
Great, I didn't realize about that
andrey-canon
approved these changes
Nov 14, 2023
This allow if the response send correct uid and there is a user with username equal, this match that user with using that uid. feat: add tests for the pipe safer associate This add tests for the pipe method `safer_associate_username_by_uid` feat: separate exceptions file Due pr recomendations is better to separate responsabilities of each file. Exception file for tpa module created. refactor: use ddt to check staff ^ superuser tests
johanseto
force-pushed
the
jlc/nid-pipeline
branch
from
497981e to
71a560d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
feat: add pipeline to match user with uid
This allow if the response send correct uid and there is a user
with username equal, this match that user with using that uid.
Additional information
Jira story?
https://edunext.atlassian.net/browse/FUTUREX-621
Checklist for Merge