feat: replace username with extrainfo national_id #222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrey-canon
commented
Oct 9, 2024
| @@ -114,6 +114,7 @@ def tearDown(self): # pylint: disable=invalid-name | |||
| self.transformer_class.get_data.reset_mock() | |||
| self.transformer_class.get_data.side_effect = None | |||
| self.transformer_class.get_object_iri.reset_mock() | |||
| modulestore.reset_mock() | |||
There was a problem hiding this comment.
This is affecting other tests since assertion depends on clean mocks
andrey-canon
force-pushed
the
and/update_national_id_references
branch
2 times, most recently
from
f4bbe6a
to
f2f58bc
Compare
andrey-canon
force-pushed
the
and/update_national_id_references
branch
from
f2f58bc
to
6d169c5
Compare
johanseto
reviewed
Oct 9, 2024
| @@ -14,7 +14,7 @@ | |||
| from ddt import data, ddt | |||
| from django.conf import settings | |||
| from django.contrib.auth import get_user_model | |||
| from django.test import override_settings | |||
| from django.test import TestCase, override_settings | |||
There was a problem hiding this comment.
Why you need to use Django test case?
There was a problem hiding this comment.
Becasue unittest.TestCase doesn't work with reverse relations, so things like user.extrainfo fails
eox_nelp/signals/receivers.py
Outdated
| @@ -355,9 +355,12 @@ def mt_course_passed_handler(user, course_id, **kwargs): # pylint: disable=unus | |||
| if not getattr(settings, "ACTIVATE_MT_TRAINING_STAGE", False): | |||
| return | |||
|
|
|||
| extra_info = getattr(user, "extrainfo", None) | |||
| national_id = extra_info.national_id if extra_info else user.username | |||
There was a problem hiding this comment.
What about if national_id is "". that would be sent?. Is weird to found same usernames. But this this field of extra_info seems allow blank
johanseto
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This replaces the username references with the extrainfo national id field
Testing instructions
Before
After
Additional information
Include anything else that will help reviewers and consumers understand the change.
Checklist for Merge