And/temporal payment notifications #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrey-canon
force-pushed
the
and/temporal_payment_notifications
branch
from
0d402b9 to
31de460
Compare
andrey-canon
force-pushed
the
and/temporal_payment_notifications
branch
4 times, most recently
from
9f1aff5 to
c0fe7e3
Compare
johanseto
force-pushed
the
and/temporal_payment_notifications
branch
from
c0fe7e3 to
3135124
Compare
andrey-canon
force-pushed
the
and/temporal_payment_notifications
branch
from
3135124 to
39452b7
Compare
Ever3tt
force-pushed
the
and/temporal_payment_notifications
branch
3 times, most recently
from
44e3736 to
68c122b
Compare
johanseto
commented
Oct 2, 2023
| @@ -1,3 +1,6 @@ | |||
| """ | |||
| ... | |||
There was a problem hiding this comment.
Add more explanation for the description
| @@ -1,9 +1,11 @@ | |||
| """ | |||
| ... | |||
| custom_msg = models.TextField( | ||
| null=True, | ||
| blank=True, | ||
| help_text='Use a "lang-ar" or "lang-en" class to select language') |
There was a problem hiding this comment.
The close parenthesis could go in new line )
eox_nelp/settings/common.py
Outdated
| try: | ||
| payments_notifications_context = 'eox_nelp.payment_notifications.context_processor.payments_notifications_context' | ||
| payments_notifications_context = 'eox_nelp.payment_notifications.context_processor.payments_notifications_context' # pylint: disable=line-too-long |
There was a problem hiding this comment.
Does this really need a skip of line-too-long or could be split into more lines?
Ever3tt
force-pushed
the
and/temporal_payment_notifications
branch
from
7509f8a to
4bf5439
Compare
johanseto
commented
Oct 2, 2023
eox_nelp/settings/common.py
Outdated
| payments_notifications_context = 'eox_nelp.payment_notifications.context_processor.payments_notifications_context' # pylint: disable=line-too-long # noqa: E501 | ||
| payments_notifications_context = ( | ||
| 'eox_nelp.payment_notifications.' | ||
| 'context_processor.payments_notifications_context') |
There was a problem hiding this comment.
The close parenthesis could go in new line )
|
Hola @andrey-canon, ya se solucionaron los errores del PR, asi vamos
|
This is a improved version of #72
andrey-canon
force-pushed
the
and/temporal_payment_notifications
branch
from
abd773f to
4022c03
Compare
andrey-canon
approved these changes
Oct 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Describe what this pull request changes, and why. Include implications for people using this change.
Useful information to include:
changes.
Testing instructions
Before
After
Additional information
Include anything else that will help reviewers and consumers understand the change.
Checklist for Merge