Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: inherit from social auth exception #192

Merged
merged 2 commits into from
Jan 4, 2024
Merged

refactor: inherit from social auth exception #192

merged 2 commits into from
Jan 4, 2024

Commits on Jan 4, 2024

  1. refactor: inherit from social auth exception 

    This change the heritance of the eox-tenant-auth-exception.

This with the purpose of the exception to be handled by the social tpa middleware exception
process.

You can see here that the new class is also based in value error exception.
https://github.com/python-social-auth/social-core/blob/29cbbd22b98d81d569a886b1cc0bd9a316cd124f/social_core/exceptions.py#L1

But the change is related with this PR:
eduNEXT/eox-core#171
So now as the exception is family  of the SocialAuthBaseException.

The the tpa middleware could managed it.
https://github.com/python-social-auth/social-app-django/blob/5.4.0/social_django/middleware.py#L35

Keep in mind that this middleware is parent of edx-platform middleware.
https://github.com/openedx/edx-platform/blob/ebcbe1cd9208191c0589d7fe538c6ac13470abe6/common/djangoapps/third_party_auth/middleware.py#L18
    @johanseto
    johanseto committed Jan 4, 2024
    Configuration menu
    Copy the full SHA
    89b9203 View commit details
    Browse the repository at this point in the history

  2. refactor: social-auth-core pkg inclusion

    @johanseto
    johanseto committed Jan 4, 2024
    Configuration menu
    Copy the full SHA
    b306762 View commit details
    Browse the repository at this point in the history