fix bug in spi bus ss pin using.

eduautomatiza · Apr 28, 2021 · 6d1d8e4 · 6d1d8e4 · iPAS · May 31, 2021
1 parent ddb7b00
commit 6d1d8e4
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 15 deletions.
diff --git a/library.properties b/library.properties
@@ -1,5 +1,5 @@
 name=LoRa
-version=0.9.5
+version=0.9.6
 author=Sandeep Mistry <sandeep.mistry@gmail.com>
 maintainer=Sandeep Mistry <sandeep.mistry@gmail.com>
 sentence=An Arduino library for sending and receiving data using LoRa radios.

diff --git a/src/LoRa.cpp b/src/LoRa.cpp
@@ -757,16 +757,12 @@ void LoRaClass::writeRegister(uint8_t address, uint8_t value) {
 
 uint8_t LoRaClass::singleTransfer(uint8_t address, uint8_t value) {
   uint8_t response;
-
-  digitalWrite(_ss, LOW);
-
   _spi->beginTransaction(_spiSettings);
+  digitalWrite(_ss, LOW);
   _spi->transfer(address);
   response = _spi->transfer(value);
-  _spi->endTransaction();
-
   digitalWrite(_ss, HIGH);
-
+  _spi->endTransaction();
   return response;
 }
 
@@ -775,23 +771,19 @@ ISR_PREFIX void LoRaClass::onDio0Rise() { LoRa.handleDio0Rise(); }
 LoRaClass LoRa;
 
 void LoRaClass::fifoTransferRead(uint8_t* buf, size_t size) {
-  digitalWrite(_ss, LOW);
-
   _spi->beginTransaction(_spiSettings);
+  digitalWrite(_ss, LOW);
   _spi->transfer(REG_FIFO);
   _spi->transferBytes(NULL, buf, size);
-  _spi->endTransaction();
-
   digitalWrite(_ss, HIGH);
+  _spi->endTransaction();
 }
 
 void LoRaClass::fifoTransferWrite(const uint8_t* buf, size_t size) {
-  digitalWrite(_ss, LOW);
-
   _spi->beginTransaction(_spiSettings);
+  digitalWrite(_ss, LOW);
   _spi->transfer(REG_FIFO | 0x80);
   _spi->transferBytes((uint8_t*)(buf), NULL, size);
-  _spi->endTransaction();
-
   digitalWrite(_ss, HIGH);
+  _spi->endTransaction();
 }