SolverConfiguration -> Action<SolverConfiguration>
#129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Convert `SolverConfiguration configuration` parameter into `Action<SolverConfiguration> configuration` in all methods, so that it can be used in an `(options => {...} )` or `(options => options.somethingsomething )`` fashion
This will maximize breaking changes reduction (i.e. when using named parameters) There will still be a breaking change, since using `null` will be ambiguous until obsolete methods are removed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Convert
SolverConfiguration configurationparameter intoAction<SolverConfiguration> configurationin all methods, so that it can be used in an(options => {...} )or(options => options.somethingsomething )fashionSee The setup "trick" that .NET libraries use and you should too video by @Elfocrash about this topic