Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor/switch #405

Merged
merged 10 commits into from
Aug 12, 2022
Merged

Refactor/switch #405

merged 10 commits into from
Aug 12, 2022

Conversation

phelpa
Copy link
Contributor

@phelpa phelpa commented Aug 4, 2022

figma : https://www.figma.com/file/WJWEph4jRV7uuVe4e9Pj13/Desktop-components-handoff?node-id=2182%3A47993

image

Agora dá pra por uma label assim : <Switch>LabelName</Switch>

Props:
defaultChecked removido
size removido
checked removido (agora é value)

Copy link
Member

@miguelaugl miguelaugl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Boa, mano, segue alguns pontos.

E adiciona o link do figma pra nóis

src/pages/ui-components/Forms/Switch/index.tsx Outdated Show resolved Hide resolved
src/pages/ui-components/Forms/Switch/index.tsx Outdated Show resolved Hide resolved
src/pages/ui-components/Forms/Switch/index.tsx Outdated Show resolved Hide resolved
src/pages/ui-components/Forms/Switch/index.tsx Outdated Show resolved Hide resolved
src/pages/ui-components/Forms/Switch/index.tsx Outdated Show resolved Hide resolved
src/pages/ui-components/Forms/Switch/index.tsx Outdated Show resolved Hide resolved
@phelpa
Copy link
Contributor Author

phelpa commented Aug 4, 2022

Boa, mano, segue alguns pontos.

E adiciona o link do figma pra nóis

opa tá lá

@ffernandomoraes
Copy link
Member

Testado e acordado alguns ajustes no privado. De resto ta lindo!

@ffernandomoraes ffernandomoraes merged commit c013b20 into develop Aug 12, 2022
@danieloprado danieloprado deleted the refactor/Switch branch March 31, 2023 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants