feat: skip literal in SwitchCase statement

don't affect litreals in its block fix #2
edvardchen · Jul 26, 2019 · d270343 · d270343
1 parent 600b5fa
commit d270343
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 0 deletions.
diff --git a/lib/rules/no-literal-string.js b/lib/rules/no-literal-string.js
@@ -197,6 +197,10 @@ module.exports = {
         if (isValidFunctionCall(parent)) visited.add(node);
       },
 
+      'SwitchCase > Literal'(node) {
+        visited.add(node);
+      },
+
       'Literal:exit'(node) {
         // visited and passed linting
         if (visited.has(node)) return;

diff --git a/tests/lib/rules/no-literal-string.js b/tests/lib/rules/no-literal-string.js
@@ -31,6 +31,7 @@ ruleTester.run('no-literal-string', rule, {
   valid: [
     { code: 'import("hello")' },
     { code: "name === 'Android' || name === 'iOS'" },
+    { code: "switch(a){ case 'a': break; default: break;}" },
     { code: 'import name from "hello";' },
     { code: 'a.indexOf("ios")' },
     { code: 'a.includes("ios")' },
@@ -61,6 +62,10 @@ ruleTester.run('no-literal-string', rule, {
 
   invalid: [
     { code: 'a + "b"', errors },
+    {
+      code: "switch(a){ case 'a': var a ='b'; break; default: break;}",
+      errors
+    },
     { code: 'export const a = "hello_string";', errors },
     { code: 'const a = "foo";', errors },
     { code: 'const a = call("Ffo");', errors },