fix: validate correctly call chains

closes #54
edvardchen · May 15, 2022 · dc33346 · dc33346
1 parent 3d479a1
commit dc33346
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 3 deletions.
diff --git a/lib/rules/no-literal-string.js b/lib/rules/no-literal-string.js
@@ -279,11 +279,13 @@ module.exports = {
       },
       'SwitchCase > Literal:exit': endIndicator,
 
-      MemberExpression(node) {
+      'MemberExpression > Literal'(node) {
         // allow Enum['value']
         indicatorStack.push(true);
       },
-      'MemberExpression:exit': endIndicator,
+      'MemberExpression > Literal:exit'(node) {
+        endIndicator();
+      },
 
       TemplateLiteral(node) {
         if (!validateTemplate) {

diff --git a/tests/lib/rules/no-literal-string/all.js b/tests/lib/rules/no-literal-string/all.js
@@ -3,7 +3,19 @@ const runTest = require('../../helpers/runTest');
 
 const cases = {
   valid: [testFile('valid.jsx')],
-  invalid: [{ ...testFile('invalid.jsx'), errors: 13 }],
+  invalid: [
+    { ...testFile('invalid.jsx'), errors: 13 },
+    {
+      code: `export const validationSchema = Yup.object({
+        email: Yup
+          .string()
+          .email('hello')
+          .required('world'),
+      })`,
+      options: [{ mode: 'all' }],
+      errors: 2,
+    },
+  ],
 };
 
 runTest('no-literal-string: mode all', cases);