feat: allow ignoring lists of components #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I had explained my concern here and plz let me know if you have different thoughts. |
|
There'll always be people ignoring stuff they shouldn't. For us not having component exclusion would mean to add a ignore line for every icon we have. While I would prefer Icon-Components, we currently don't have them and it would be part of a bigger refactoring to change that. |
|
Well, I understand your situation. And I cannot offer another effective solution for your case. Why not merge your MR? |
|
release as v4.2.0 @boredland |
|
thank you very much 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we needed this for an icon component that retrieves string literals. thought it might be useful.