Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature to validate certificate for a SSL connection #76

Closed

Conversation

niteesh19
Copy link

@niteesh19 niteesh19 commented Jun 6, 2017

Custom TrustManager for validating cert digest
Linked to:
https://github.com/edvin/fxldemo-gradle/issues/8

This is implemented as the cacheDir parameter.

Couple of concerns:

  1. I have added a new dependency of httpclient v4.5.2 because of which in the pom.xml I had to add maven-assembly-plugin which creates an executable jar with this string appended at the last of the jar name "-jar-with-dependencies". So the maven now basically installs two jars; one fxlauncher-1.0.17-SNAPSHOT.jar and one fxlauncher-1.0.17-SNAPSHOT-jar-with-dependencies.jar. The second jar needs to be referenced by the project fxlauncher-gradle-plugin.
  2. I wanted to add a HttpsURLConnection.setDefaultHostnameVerifier() which basically would verify the hostname of the connecting url and the hostname from the "applicationUrl" specified in the gradle build. But I was not able to do it as the HostnameVerifier gets ignored (don't know why.) Should this be present ? Please let me know if you have a way of implementing this. Even if not implemented, this works fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant