Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split code into core and submodules for non-core code #5

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Split code into core and submodules for non-core code #5

wants to merge 2 commits into from

Conversation

ctadlock
Copy link
Collaborator

The first commit for this merge request. DO NOT MERGE YET

Items:

  • Split project into parent and submodules
  • Moved all code into tornadofx-core submodule
  • Completely rewrote the pom.xml files
  • Did not move over test code; I think this should be reviewed first
  • Did not move over documentation via dokka; not sure how this works yet

@ctadlock
Copy link
Collaborator Author

#3

@ctadlock ctadlock requested a review from edvin May 19, 2020 22:22
@ctadlock
Copy link
Collaborator Author

@edvin Take a look at this for the structure; you should be able to pull it down and use it. I was able to use it in our app without any issue. If youre OK with this, can then work on moving the components out of core into their other projects.

@ctadlock ctadlock changed the title Move all existing code into tornadofx-core; change version to 2.1 Split code into core and submodules for non-core code May 20, 2020
@ruckustboom ruckustboom marked this pull request as draft May 20, 2020 17:57
@ruckustboom
Copy link
Collaborator

I converted this PR to a draft/WIP to prevent accidental merging. When you're ready for it to be merged, mark it as "Ready for review".

@ctadlock
Copy link
Collaborator Author

I converted this PR to a draft/WIP to prevent accidental merging. When you're ready for it to be merged, mark it as "Ready for review".

Thanks. Ill be the one to merge it anyways, but good to follow the right process.

@ctadlock
Copy link
Collaborator Author

Going to merge this in and start moving forward...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants