Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manual upgrades update #9

Merged
merged 4 commits into from
Apr 30, 2024
Merged

Manual upgrades update #9

merged 4 commits into from
Apr 30, 2024

Conversation

rijuma
Copy link
Member

@rijuma rijuma commented Apr 29, 2024

Open edX is deprecating several repositories, Team Cosmonauts is taking ownership of edx-analytics-dashboard, edx-analytics-data-api and edx-analytics-data-api-client to maintain them.

Copy link
Member

@varshamenon4 varshamenon4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

robrap
robrap previously requested changes Apr 29, 2024
Copy link

@robrap robrap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In addition to the doc update, there are references that need to be update in devstack. See

"https://github.com/openedx/edx-analytics-dashboard.git"
as an example, but there are more.

@timmc-edxis familiar with searching across all our repos for outdated references. I'm not sure if the "forking into the edx org" doc has or needs tips for that?

@rijuma
Copy link
Member Author

rijuma commented Apr 29, 2024

In addition to the doc update, there are references that need to be update in devstack. See

"https://github.com/openedx/edx-analytics-dashboard.git"

as an example, but there are more.
@timmc-edxis familiar with searching across all our repos for outdated references. I'm not sure if the "forking into the edx org" doc has or needs tips for that?

Thanks for the warning. I've updated the references for edx-analytics-dashboard and edx-analytics-data-api. Couldn't find any reference for edx-analytics-data-api-client. I think it's not part of devstack.


- **edx-analytics-dashboard**::

git remote set-url origin git@github.com:edx/edx-analytics-dashboard.git
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure how you want to represent the devstack working dir in the following, but do you want some version of the following before each? Not sure if you even need the headers, or if you just want one large code block. Your decision.

cd edx-analytics-dashboard

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated instructions, maybe it's clearer now. What do you think?

@robrap robrap dismissed their stale review April 29, 2024 20:27

I don't want to be a blocker.

@rijuma rijuma force-pushed the rijuma/manual-upgrades-2024-04-29 branch from 2ba91e1 to 1ca56b9 Compare April 29, 2024 20:52
@rijuma rijuma force-pushed the rijuma/manual-upgrades-2024-04-29 branch from 1ca56b9 to d5fc4f8 Compare April 29, 2024 20:52
Copy link

@robrap robrap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One non-blocking comment. Thanks.

docs/manual_upgrades.rst Outdated Show resolved Hide resolved
@rijuma rijuma force-pushed the rijuma/manual-upgrades-2024-04-29 branch from cd9ef6f to 3d974ef Compare April 30, 2024 12:18
@rijuma rijuma force-pushed the rijuma/manual-upgrades-2024-04-29 branch from 3d974ef to b7489d6 Compare April 30, 2024 12:24
@rijuma rijuma merged commit 2869852 into master Apr 30, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants