-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Manual upgrades update #9
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In addition to the doc update, there are references that need to be update in devstack. See
Line 37 in 36f1bcd
"https://github.com/openedx/edx-analytics-dashboard.git" |
@timmc-edxis familiar with searching across all our repos for outdated references. I'm not sure if the "forking into the edx org" doc has or needs tips for that?
Thanks for the warning. I've updated the references for |
docs/manual_upgrades.rst
Outdated
|
||
- **edx-analytics-dashboard**:: | ||
|
||
git remote set-url origin git@github.com:edx/edx-analytics-dashboard.git |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure how you want to represent the devstack working dir in the following, but do you want some version of the following before each? Not sure if you even need the headers, or if you just want one large code block. Your decision.
cd edx-analytics-dashboard
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated instructions, maybe it's clearer now. What do you think?
2ba91e1
to
1ca56b9
Compare
1ca56b9
to
d5fc4f8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One non-blocking comment. Thanks.
cd9ef6f
to
3d974ef
Compare
3d974ef
to
b7489d6
Compare
Open edX is deprecating several repositories, Team Cosmonauts is taking ownership of edx-analytics-dashboard, edx-analytics-data-api and edx-analytics-data-api-client to maintain them.