Merge pull request #56 from edx/hassan/fix-s3-delete-directory

chore: skip deletion if there are no keys under prefix.
edx · Jan 14, 2022 · 3d99ddb · 3d99ddb
2 parents de84d51 + 92bee3b
commit 3d99ddb
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 8 deletions.
diff --git a/edx_prefectutils/__init__.py b/edx_prefectutils/__init__.py
@@ -2,4 +2,4 @@
 Top-level package for edx-prefectutils.
 """
 
-__version__ = '2.2.4'
+__version__ = '2.2.5'
diff --git a/edx_prefectutils/s3.py b/edx_prefectutils/s3.py
@@ -19,13 +19,14 @@ def delete_s3_directory(bucket: str = None, prefix: str = None, credentials: dic
         credentials (dict): The AWS credentials to use.
     """
     s3_keys = list_object_keys_from_s3.run(bucket, prefix, credentials)
-    s3_client = get_boto_client('s3', credentials=credentials)
-    s3_client.delete_objects(
-        Bucket=bucket,
-        Delete={
-            'Objects': [{'Key': key} for key in s3_keys]
-        }
-    )
+    if s3_keys:
+        s3_client = get_boto_client('s3', credentials=credentials)
+        s3_client.delete_objects(
+            Bucket=bucket,
+            Delete={
+                'Objects': [{'Key': key} for key in s3_keys]
+            }
+        )
 
 
 @task