chore: remove sysadmin part2

[katebygrace]

JIRA:CLOUDSEC-12

[matthugs]

I don't think this will work. The contents of the devops/jenkins folder doesn't automatically end up in jobs' workspaces. Lines like

jenkins-job-dsl/devops/jobs/SAMLSSLExpirationCheck.groovy

Line 48 in 183a1e8

shell(dslFactory.readFileFromWorkspace('devops/resources/saml-ssl-expiration-check.sh'))

don't add anything to the workspace; they dump the contents of that file into the job's configuration, like this:

I think we need to get these files cloned into the workspace from somewhere. It doesn't have to be from edx-ops/sysadmin per se, but we have to clone something (or embed the python code in the shell file or some such hacky replumbing).

I'm not sure I understand the rationale for trying to remove references to the sysadmin repo in the first place; is there a more specific ticket you can reference for which work this pertains to? Could we create a repo specifically for scripts we're migrating out of edx-ops repos we'd like to delete off Github? Or put these in https://github.com/openedx/configuration/tree/master/util like the sysadmin README suggests?

[matthugs]

we probably want to add some txt files to the .gitignore in this repo if we copy these into here

[matthugs]

Suggested change

	pip install -r ../eequirements/base.txt
	pip install -r ../requirements/base.txt

[katebygrace]

re: rationale; sysadmin has credentials in it, so when we clone that onto jenkins we're back in plaintext password land; which we're moving off of, that said will give this a look over

[matthugs]

re: sysadmin having credentials in it, great that makes sense & is what I expected you to say.