chore: migrate analytics exporter #1728
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
katebygrace
force-pushed
the
katebygrace/analytics-exporter
branch
from
4486ae1 to
d49d83f
Compare
| @@ -133,6 +133,9 @@ class AnalyticsEmailOptin { | |||
| // This will create python 3.8 venv inside shell script instead of using shiningpanda | |||
| shell(dslFactory.readFileFromWorkspace('dataeng/resources/setup-platform-venv-py3.sh')) | |||
| shell(dslFactory.readFileFromWorkspace('dataeng/resources/setup-exporter-email-optin.sh')) | |||
| shell(dslFactory.readFileFromWorkspace('dataeng/analytics-exporter/email_optin.yaml')) | |||
There was a problem hiding this comment.
I don't think this will work as I believe shell is for running a shell command only.
There was a problem hiding this comment.
Okay, I was just trying to pull in the file, but I think it's already in there, am I correct?
| # Configuration paths in analytics-secure | ||
| SECURE_ROOT=${WORKSPACE}/analytics-secure/analytics-exporter | ||
| SECURE_ROOT=${WORKSPACE}/dataeng/analytics-exporter |
There was a problem hiding this comment.
I believe this would not work as this repo(jenkins-job-dsl), does not get cloned as part of this job.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
there wasnt any sensitive info in these files so i think they can be safely copied, cloned, and called. hopefully got it correct