Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: switch to drf-yasg #152

Merged
merged 1 commit into from
Oct 22, 2021
Merged

Conversation

ericfab179
Copy link
Contributor

Move from django-rest-swagger to drf-yasg and edx_api_doc_tools.

Address upgrade issue edx/upgrades#17

@openedx-webhooks
Copy link

Thanks for the pull request, @ericfab179! I've created OSPR-6125 to keep track of it in JIRA, where we prioritize reviews. Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@codecov-commenter
Copy link

codecov-commenter commented Oct 11, 2021

Codecov Report

Merging #152 (b5e4ff7) into master (6e6c108) will increase coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #152      +/-   ##
==========================================
+ Coverage   90.25%   90.29%   +0.04%     
==========================================
  Files          29       29              
  Lines         872      876       +4     
  Branches      111      111              
==========================================
+ Hits          787      791       +4     
  Misses         66       66              
  Partials       19       19              
Impacted Files Coverage Δ
designer/urls.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e6c108...b5e4ff7. Read the comment docs.

@awais786
Copy link
Contributor

Please fix quality issues.

'social_django',
'waffle',
'modelcluster',
'simplejson',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need this package to use drf_yasg ?

@ericfab179 ericfab179 force-pushed the ednx/edx-upgrade-swagger branch from e5b8f08 to 11e31d8 Compare October 13, 2021 02:41
@natabene
Copy link

@ericfab179 Thank you for your contribution.

@schenedx
Copy link
Member

@ericfab179 I just merged in a requirements update which conflicted with this PR. I am sorry about that. Could you please update this PR to the latest on master branch?

Move from django-rest-swagger to drf-yasg and edx_api_doc_tools.
@ericfab179 ericfab179 force-pushed the ednx/edx-upgrade-swagger branch from 847ab0e to b5e4ff7 Compare October 21, 2021 02:49
@ericfab179
Copy link
Contributor Author

@natabene @schenedx @awais786 is it ready to merge now ?

@awais786
Copy link
Contributor

@schenedx It's ready to merge.

@schenedx schenedx merged commit a21b2e8 into edx:master Oct 22, 2021
@openedx-webhooks
Copy link

@ericfab179 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants