-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: switch to drf-yasg #152
Conversation
Thanks for the pull request, @ericfab179! I've created OSPR-6125 to keep track of it in JIRA, where we prioritize reviews. Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
Codecov Report
@@ Coverage Diff @@
## master #152 +/- ##
==========================================
+ Coverage 90.25% 90.29% +0.04%
==========================================
Files 29 29
Lines 872 876 +4
Branches 111 111
==========================================
+ Hits 787 791 +4
Misses 66 66
Partials 19 19
Continue to review full report at Codecov.
|
Please fix quality issues. |
designer/settings/base.py
Outdated
'social_django', | ||
'waffle', | ||
'modelcluster', | ||
'simplejson', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need this package to use drf_yasg
?
e5b8f08
to
11e31d8
Compare
@ericfab179 Thank you for your contribution. |
941cc70
to
847ab0e
Compare
@ericfab179 I just merged in a requirements update which conflicted with this PR. I am sorry about that. Could you please update this PR to the latest on master branch? |
Move from django-rest-swagger to drf-yasg and edx_api_doc_tools.
847ab0e
to
b5e4ff7
Compare
@schenedx It's ready to merge. |
@ericfab179 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
Move from django-rest-swagger to drf-yasg and edx_api_doc_tools.
Address upgrade issue edx/upgrades#17