Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: django40 warnings removed #257

Merged
merged 2 commits into from
Sep 14, 2023
Merged

fix: django40 warnings removed #257

merged 2 commits into from
Sep 14, 2023

Conversation

zubairshakoorarbisoft
Copy link
Contributor

No description provided.

@zubairshakoorarbisoft zubairshakoorarbisoft changed the title fix: django40 warnings rmeoved fix: django40 warnings removed Sep 11, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #257 (1391d08) into master (6c5c604) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #257   +/-   ##
=======================================
  Coverage   84.78%   84.78%           
=======================================
  Files          60       60           
  Lines        1196     1196           
  Branches      128      128           
=======================================
  Hits         1014     1014           
  Misses        159      159           
  Partials       23       23           
Files Changed Coverage Δ
designer/apps/api/urls.py 100.00% <100.00%> (ø)
designer/apps/api/v1/urls.py 100.00% <100.00%> (ø)
designer/apps/core/models.py 100.00% <100.00%> (ø)
designer/urls.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@UsamaSadiq UsamaSadiq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we use path instead of re_path on the paths where no regex is being used as url?

@zubairshakoorarbisoft
Copy link
Contributor Author

Shouldn't we use path instead of re_path on the paths where no regex is being used as url?

@UsamaSadiq almost all the urls having regex were using url(), that's why used re path.

@UsamaSadiq UsamaSadiq merged commit 9439350 into master Sep 14, 2023
6 checks passed
@UsamaSadiq UsamaSadiq deleted the zshkoor/warnings-removal branch September 14, 2023 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants