Header refactor 153536 #226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- introduced 2 extra values to account for other values used in the design system
- use 1.2 for all headings as discussed in design meetings
- in numbers only due to calculations otherwise they are rendered really small
…adings, body, caption and small text
…urus - in the typographic guide it makes sense to actually implement the values that are described and the best way to see how they look is to use the same font
- Modified letter spacing to use 1%, 1.5% positive and negative values after looking at figma implementation and docusaurus documentation - Added information about the line height used by headers which is different from the body text - Modified font sizes with the latest values - Added font size also in px so easier understanding of values as opposed to rem values - Modified fluid font sizes now that we no longer have values higher than 2.75rem - Modified font family stack of docusaurus to include Arial fallback as described in the typography section - Use tiny class for 12px small text in line with our tiny class from Semantic
- bringing the color from the design system also in the docusaurus site
…rroring the design system styles - added letter spacing to the text examples from typography section
…cusaurus - tweaked lineheight-0 since the headers now use 1.2 instead of 1.25
- tiny and discreet class have some letterspacing applied as documented in docusaurus
…n easily choose another heading color - also introduced contentAreaColor since this color will probably only be set for the new eea website
…d inherit color - this way we keep the same sizes as in the figma file even though the hero uses an h2 tag
…f using the tertiary color
- this way if we place a header in a content box and it has a color set the headers will also switch to that color
|
To generate the Storybook and Docusaurus websites, write comment with:
To generate only Storybook write comment with:
To generate only Docusaurus write comment with:
|
|
@eea-jenkins build all |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.