Release #374
Merged
Release #374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to a generic function - this way we can use it in other places when we need to check for enter key and call a callback within that event handler
- and avoid need for text state, we don't need to re-render the component each time the user types, we are only interested in the final value of the input in order to know with what value we need to give to q
- this way we can use buttons instead of i tags to provide a proper submit button for the search form which is read properly by screen readers
…support [ACCESSIBILITY 2.1.1.1] #360 from eea/refactor-search-input-icon
…ontain accessibility labels
…a carousel region - Following examples of changes made in an accessible carousel version of slick carousel found at https://accessible360.github.io/accessible-slick/
…which slide we are on
- also made some changes to the statistic stories in order to avoid React warnings, initially only for the Default story
|
👋 @avoinea To generate the Storybook and Docusaurus websites, write comment with:
To generate only Storybook write comment with:
To generate only Docusaurus write comment with:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.