feat: show error on change not on submit, fix error message

eea · Mar 1, 2023 · fb844f5 · fb844f5
1 parent 9bfffd9
commit fb844f5
Showing 1 changed file with 8 additions and 6 deletions.
diff --git a/src/NextCloud/NextCloudVideoEdit.jsx b/src/NextCloud/NextCloudVideoEdit.jsx
@@ -122,10 +122,12 @@ class Edit extends Component {
    * @returns {undefined}
    */
   onSubmitUrl() {
-    this.props.onChangeBlock(this.props.block, {
-      ...this.props.data,
-      url: this.state.url,
-    });
+    if (this.isValidUrl(this.state.url)) {
+      this.props.onChangeBlock(this.props.block, {
+        ...this.props.data,
+        url: this.state.url,
+      });
+    }
   }
 
   resetSubmitUrl = () => {
@@ -218,11 +220,11 @@ class Edit extends Component {
                 </Button>
               </Button.Group>
             </div>
-            {data.url && !this.isValidUrl(data.url) && (
+            {this.state.url && !this.isValidUrl(this.state.url) && (
               <Message
                 error
                 content={`${this.props.intl.formatMessage(
-                  messages.VideoBlockInputPlaceholder,
+                  messages.VideoBlockInputError,
                 )} ${this.allowedDomainList.join(', ')}`}
               />
             )}