check if eventEmitter exists

eea · Jul 25, 2024 · d2e244d · d2e244d
1 parent b36b682
commit d2e244d
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/searchlib/components/Facets/Wrappers/AccordionFacetWrapper.jsx b/searchlib/components/Facets/Wrappers/AccordionFacetWrapper.jsx
@@ -38,6 +38,7 @@ const AccordionFacetWrapper = (props) => {
 
   const onChangeFilterType = (v) => {
     setLocalFilterType(v);
+    if (!eventEmitter) return;
     eventEmitter.emit('change:filterType', {
       field,
       type: v,
@@ -57,6 +58,8 @@ const AccordionFacetWrapper = (props) => {
   }, [hasFilter, field, openFacets, updateOpenFacets]);
 
   React.useEffect(() => {
+    if (!eventEmitter) return;
+
     function changeFilterType(data) {
       if (data.field === field) {
         setLocalFilterType(data.type);
@@ -68,7 +71,7 @@ const AccordionFacetWrapper = (props) => {
     return () => {
       eventEmitter.off('change:filterType', changeFilterType);
     };
-  }, []);
+  }, [eventEmitter]);
 
   let isOpened = openFacets[field]?.opened || false;
   const [counter, setCounter] = React.useState(0);

diff --git a/searchlib/components/Facets/Wrappers/DropdownFacetWrapper.jsx b/searchlib/components/Facets/Wrappers/DropdownFacetWrapper.jsx
@@ -65,13 +65,16 @@ const DropdownFacetWrapper = (props) => {
 
   const onChangeFilterType = (v) => {
     setLocalFilterType(v);
+    if (!eventEmitter) return;
     eventEmitter.emit('change:filterType', {
       field,
       type: v,
     });
   };
 
   React.useEffect(() => {
+    if (!eventEmitter) return;
+
     function changeFilterType(data) {
       if (data.field === field) {
         setLocalFilterType(data.type);
@@ -83,7 +86,7 @@ const DropdownFacetWrapper = (props) => {
     return () => {
       eventEmitter.off('change:filterType', changeFilterType);
     };
-  }, []);
+  }, [eventEmitter]);
 
   const { width } = useWindowDimensions();
   const isSmallScreen = width < SMALL_SCREEN_SIZE;