Remove height setting, solve no source link bug

eea · Jan 23, 2023 · 03216e3 · 03216e3
1 parent 78cb29f
commit 03216e3
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 17 deletions.
diff --git a/src/Blocks/EmbedEEATableauBlock/schema.js b/src/Blocks/EmbedEEATableauBlock/schema.js
@@ -47,19 +47,14 @@ const Schema = (props) => {
       {
         id: 'default',
         title: 'Default',
-        fields: ['vis_url', 'height', 'show_sources', 'dataprotection'],
+        fields: ['vis_url', 'show_sources', 'dataprotection'],
       },
     ],
     properties: {
       vis_url: {
         widget: 'object_by_path',
         title: 'Visualization',
       },
-      height: {
-        title: 'Height',
-        type: 'number',
-        default: 450,
-      },
       show_sources: {
         title: 'Toggle sources',
         type: 'boolean',

diff --git a/src/Sources/Sources.jsx b/src/Sources/Sources.jsx
@@ -28,17 +28,19 @@ const SourcesWidget = ({ sources }) => {
         <ul>
           {sources &&
             sources.data &&
-            sources.data.map((param, i) => (
-              <li key={i} className="embed-source-param">
-                <UniversalLink
-                  className="embed-sources-param-title"
-                  href={param.link}
-                >
-                  {param.title}
-                </UniversalLink>
-                , {param.organisation}
-              </li>
-            ))}
+            sources.data.map((param, i) =>
+              param.link ? (
+                <li key={i} className="embed-source-param">
+                  <UniversalLink
+                    className="embed-sources-param-title"
+                    href={param.link}
+                  >
+                    {param.title}
+                  </UniversalLink>
+                  , {param.organisation}
+                </li>
+              ) : null,
+            )}
         </ul>
       )}
     </div>