Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lintable expansion #161

Merged
merged 2 commits into from
Aug 6, 2024
Merged

Lintable expansion #161

merged 2 commits into from
Aug 6, 2024

Conversation

som-snytt
Copy link

On 2.13.14, -Wmacros:after -Xlint:missing-interpolator will warn on the expanded assert that includes an interpolation.

Fix that by concatenating pieces of the string that represents the source text.

Also update dependencies, but run into trouble with 2.11.

A couple of tests require tweaked output because of how List() is rewritten to Nil. (The rewrite broke early in 2.13.x. I did not update Scala 3 or look into its behavior.)

Checked with local project that it passes lint and displays correctly

[error] assert(c.m == s"hello, $world")
[error]        | | |            |
[error]        | | false        hello, worldx
[error]        | hello, world
[error]        p.C@64687a13

@SethTisue
Copy link

@som-snytt should this still be "draft"...?

@som-snytt som-snytt marked this pull request as ready for review August 5, 2024 23:58
@som-snytt
Copy link
Author

It says there is a problem on 2.11.x.

@SethTisue
Copy link

eh? checks are green

(regardless, I suspect Eugene would be open to a PR removing 2.11 from the crossbuild, at this point)

@som-snytt
Copy link
Author

This comments out 2.11 ... sneaky! Amazing that sort of thing doesn't happen more often.

Copy link
Owner

@eed3si9n eed3si9n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants