Adds source location #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* The source location contains both absolute and relative (to the wd at build time) paths, as well as the line number. * The location information is communicated to the front-end via the RecordedExpression. * Adds a flag (disabled by default) to the `Expecty` constructor to display the source location in the error message.
eed3si9n
reviewed
Sep 26, 2020
| class Expecty extends Recorder[Boolean, Unit] { | ||
| class Expecty(displayLoc: Boolean = false) extends Recorder[Boolean, Unit] { |
There was a problem hiding this comment.
It may be more consistent to put this into val like failEarly and showTypes?
There was a problem hiding this comment.
🤦 hadn't notice those. Addressed : 73f89d0
eed3si9n
approved these changes
Sep 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expectyconstructor to display the source location in the error message.