Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug when shading ScalaLongSignature #10

Merged
merged 1 commit into from
Mar 27, 2021
Merged

Fix bug when shading ScalaLongSignature #10

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions core/src/main/scala/com/eed3si9n/jarjarabrams/scalasig/ScalaSigAnnotationVisitor.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ class ScalaSigAnnotationVisitor(

private val MaxStringSizeInBytes = 65535
private val annotationBytes: ByteArrayOutputStream = new ByteArrayOutputStream()
private var hasWrittenAnnotation = false

override def visit(name: String, value: Any): Unit = {
// Append all the annotation bytes, whether is is a long or normal signature
Expand All @@ -40,6 +41,15 @@ class ScalaSigAnnotationVisitor(
}

override def visitEnd(): Unit = {
if (!hasWrittenAnnotation) {
// This method is called as many times as visit() was called,
// but we only want to write the annotation once
rewriteAnnotation()
hasWrittenAnnotation = true
}
}

def rewriteAnnotation(): Unit = {
val encoded = annotationBytes.toByteArray
val len = ByteCodecs.decode(encoded)

Expand Down