Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

In source now-defunct Pants team fork of Jar Jar Links #15

Merged
merged 189 commits into from
Aug 25, 2021
Merged

In source now-defunct Pants team fork of Jar Jar Links #15

merged 189 commits into from
Aug 25, 2021

Conversation

er1c
Copy link
Collaborator

@er1c er1c commented Aug 24, 2021 •
edited
Loading

Addresses #11 (at least partially) and fixing #15

  • Created a copy of https://github.com/pantsbuild/jarjar with git-history as jarjar subproject
  • Updated build.sbt and README to reference the jarjar project and where it came from
  • Added a KeepProcessorTest and fix.
  • Added a best-guess for BigtableIO$Write.class since no version was available (test passes though)
  • Moved the org.pantsbuild.jarjar.integration into jarjar/src/it and removed the pants dependency

See updated README.markdown

@er1c er1c marked this pull request as draft August 24, 2021 04:33
@er1c er1c force-pushed the add-pants-jarjar branch 2 times, most recently from 89500e6 to eafd83e Compare August 24, 2021 04:47
@er1c
Copy link
Collaborator Author

er1c commented Aug 24, 2021

Verified that this fixes the sbt-assembly test failure, but I'd like to do some more tests, I need to split the actual fix out from the big commit too to make easier to review.

@er1c er1c force-pushed the add-pants-jarjar branch from eafd83e to b3e8a90 Compare August 24, 2021 15:24
@er1c er1c mentioned this pull request Aug 24, 2021
Closed
root and others added 24 commits August 24, 2021 09:05
@er1c er1c force-pushed the add-pants-jarjar branch from b3e8a90 to 24c8100 Compare August 24, 2021 16:14
@er1c er1c force-pushed the add-pants-jarjar branch from 8d919e8 to 80a52b7 Compare August 24, 2021 16:34
@er1c
Copy link
Collaborator Author

er1c commented Aug 24, 2021

@alexarchambault do you want to review this? what was the issue with the ASM?

@er1c er1c marked this pull request as ready for review August 24, 2021 16:46
@er1c er1c mentioned this pull request Aug 24, 2021
Closed
eed3si9n
eed3si9n reviewed Aug 24, 2021
View reviewed changes
README.markdown Outdated Show resolved Hide resolved
eed3si9n
eed3si9n reviewed Aug 24, 2021
View reviewed changes
README.markdown Outdated Show resolved Hide resolved
@ericdotdata ericdotdata mentioned this pull request Aug 24, 2021
Closed
@er1c
Copy link
Collaborator Author

er1c commented Aug 24, 2021

✅ with the CI tests now running/passing

@eed3si9n eed3si9n changed the title Add jarjar-pants In source now-defunct Pants team fork of Jar Jar Links Aug 25, 2021
eed3si9n
eed3si9n approved these changes Aug 25, 2021
View reviewed changes
Copy link
Owner

@eed3si9n eed3si9n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@eed3si9n eed3si9n merged commit e92a8f6 into eed3si9n:develop Aug 25, 2021
@eed3si9n eed3si9n mentioned this pull request Sep 1, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eed3si9n eed3si9n eed3si9n approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.