Fix Cosmology.from_sigma8() for a_stop!=1 #31
+62
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #30 Adrian mentioned that current growth function is tabulated between
a_start
anda_stop
, and the growth function gives wrong values for input scale factor out of the region because of the extrapolation behavior ofjax.numpy.interp
. This can be fixed by always tabulating the growth from a=0 to a=1 in theconfigration
.