Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Cosmology.from_sigma8() for a_stop!=1 #31

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

pointeee
Copy link

In #30 Adrian mentioned that current growth function is tabulated between a_start and a_stop, and the growth function gives wrong values for input scale factor out of the region because of the extrapolation behavior of jax.numpy.interp. This can be fixed by always tabulating the growth from a=0 to a=1 in the configration.

@adrianbayer
Copy link

Previously the code only calculated the growth at the exact a values of the nbody sim, but now it computes it at an arbitrary linspace. Would something like jnp.concatenate((self.a_lpt, self.a_nbody[1:], [1])) be better? I.e. just adding [1] as an extra concatenation so that it's the same as the old code, but also with a=1.

@eelregit eelregit changed the title FIx Cosmology.from_sigma8() for a_stop!=1 Fix Cosmology.from_sigma8() for a_stop!=1 Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants