Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename tags option as customTags #107

Merged
merged 3 commits into from
Apr 5, 2019
Merged

Rename tags option as customTags #107

merged 3 commits into from
Apr 5, 2019

Conversation

eemeli
Copy link
Owner

@eemeli eemeli commented Apr 5, 2019

I've started to think that it's unclear to call the custom tags option just tags, as there are of course additional tags as well that'll be used by the schema. So I'm here renaming it as customTags. Using the old name will still work, but will now produce a deprecation warning.

In node environments the warning uses process.emitWarning internally, so its behaviour can be controlled by the --{throw,no,trace}-deprecation command-line options. Additionally, setting a global _YAML_SILENCE_DEPRECATION_WARNINGS to true will also silence the warnings.

@eemeli eemeli changed the title Rename tags option as customt Rename tags option as customTags Apr 5, 2019
eemeli added a commit to eemeli/yaml-docs that referenced this pull request Apr 5, 2019
@eemeli eemeli merged commit 154f217 into master Apr 5, 2019
@eemeli eemeli deleted the rename-tags-option branch April 5, 2019 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant