Refactor logging control, adding logLevel option #215
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the logging controllable via a new option:
The default is
'warn'
, and acts pretty much as previously. At least for now'debug'
doesn't add anything on top of it.Setting
logLevel: 'error'
silences warnings duringYAML.parse()
anddoc.toJS()
.Setting
logLevel: 'silent'
also does its best to silence even parsing errors, resulting in output that should represent at least a part of the original input, even if it isn't entirely valid YAML.As a related change, the warning about casting collections to string when used a map key &
mapAsMap
is not enabled is now emitted only during thetoJS()
call, rather than being added to thedoc.warnings
array.