Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(merge): no error when key is null #29

Merged
merged 2 commits into from
Aug 4, 2018
Merged

fix(merge): no error when key is null #29

merged 2 commits into from
Aug 4, 2018

Conversation

ikatyang
Copy link
Contributor

@ikatyang ikatyang commented Aug 4, 2018

iKey is possible to be null.

@eemeli
Copy link
Owner

eemeli commented Aug 4, 2018

Any chance you could add a test case for this as well?

@ikatyang
Copy link
Contributor Author

ikatyang commented Aug 4, 2018

Actually, I didn't do so since I'm not sure where to put it, or should I add a new test file?

@eemeli
Copy link
Owner

eemeli commented Aug 4, 2018

Should probably clean up at least the test file names at some point. corner-cases.js has turned into a bit of a catch-all, but anchors.js works as well for this.

@eemeli eemeli merged commit 3f5fda1 into eemeli:master Aug 4, 2018
@ikatyang ikatyang deleted the fix/no-error-on-empty-key-with-merge-enabled branch August 4, 2018 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ikatyang @eemeli