enable macOS tests for LightGBM. (dotnet#422)

eerhardt · Jul 27, 2018 · fbde8a0 · fbde8a0
1 parent 05863c8
commit fbde8a0
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 50 deletions.
diff --git a/test/Microsoft.ML.Predictor.Tests/TestAutoInference.cs b/test/Microsoft.ML.Predictor.Tests/TestAutoInference.cs
@@ -26,11 +26,6 @@ public TestAutoInference(ITestOutputHelper helper)
         [TestCategory("EntryPoints")]
         public void TestLearn()
         {
-            //Skip this test for macOS until engineering system installs OpenMP dependency for 
-            //native LightGBM library.
-            if (RuntimeInformation.IsOSPlatform(OSPlatform.OSX))
-                return;
-
             using (var env = new TlcEnvironment())
             {
                 string pathData = GetDataPath("adult.train");
@@ -280,11 +275,6 @@ public void EntryPointPipelineSweep()
         [Fact]
         public void TestRocketPipelineEngine()
         {
-            //Skip this test for macOS until engineering system installs OpenMP dependency for 
-            //native LightGBM library.
-            if (RuntimeInformation.IsOSPlatform(OSPlatform.OSX))
-                return;
-
             // Get datasets
             var pathData = GetDataPath("adult.train");
             var pathDataTest = GetDataPath("adult.test");

diff --git a/test/Microsoft.ML.Predictor.Tests/TestPredictors.cs b/test/Microsoft.ML.Predictor.Tests/TestPredictors.cs
@@ -413,11 +413,6 @@ public void FastTreeBinaryClassificationTest()
         [TestCategory("LightGBM")]
         public void LightGBMClassificationTest()
         {
-            //Skip this test for macOS until engineering system installs OpenMP dependency for 
-            //native LightGBM library.
-            if (RuntimeInformation.IsOSPlatform(OSPlatform.OSX))
-                return;
-
             var learners = new[] { TestLearners.LightGBMClassifier };
             var binaryClassificationDatasets = new List<TestDataset> { TestDatasets.breastCancerPipe };
             foreach (var learner in learners)
@@ -433,11 +428,6 @@ public void LightGBMClassificationTest()
         [TestCategory("Binary"), TestCategory("LightGBM")]
         public void GossLightGBMTest()
         {
-            //Skip this test for macOS until engineering system installs OpenMP dependency for 
-            //native LightGBM library.
-            if (RuntimeInformation.IsOSPlatform(OSPlatform.OSX))
-                return;
-
             var binaryPredictors = new[] { TestLearners.LightGBMGoss };
             var binaryClassificationDatasets = new List<TestDataset> { TestDatasets.breastCancerPipe };
             RunAllTests(binaryPredictors, binaryClassificationDatasets, extraTag: "goss");
@@ -449,11 +439,6 @@ public void GossLightGBMTest()
         [TestCategory("LightGBM")]
         public void DartLightGBMTest()
         {
-            //Skip this test for macOS until engineering system installs OpenMP dependency for 
-            //native LightGBM library.
-            if (RuntimeInformation.IsOSPlatform(OSPlatform.OSX))
-                return;
-
             var binaryPredictors = new[] { TestLearners.LightGBMDart };
             var binaryClassificationDatasets = new List<TestDataset> { TestDatasets.breastCancerPipe };
             RunAllTests(binaryPredictors, binaryClassificationDatasets, extraTag: "dart");
@@ -468,11 +453,6 @@ public void DartLightGBMTest()
         [TestCategory("LightGBM")]
         public void MultiClassifierLightGBMKeyLabelTest()
         {
-            //Skip this test for macOS until engineering system installs OpenMP dependency for 
-            //native LightGBM library.
-            if (RuntimeInformation.IsOSPlatform(OSPlatform.OSX))
-                return;
-
             var multiPredictors = new[] { TestLearners.LightGBMMC };
             var multiClassificationDatasets = new[] { TestDatasets.irisLoader };
             RunAllTests(multiPredictors, multiClassificationDatasets, extraTag: "key");
@@ -487,11 +467,6 @@ public void MultiClassifierLightGBMKeyLabelTest()
         [TestCategory("LightGBM")]
         public void MultiClassifierLightGBMKeyLabelU404Test()
         {
-            //Skip this test for macOS until engineering system installs OpenMP dependency for 
-            //native LightGBM library.
-            if (RuntimeInformation.IsOSPlatform(OSPlatform.OSX))
-                return;
-
             var multiPredictors = new[] { TestLearners.LightGBMMC };
             var multiClassificationDatasets = new[] { TestDatasets.irisLoaderU404 };
             RunAllTests(multiPredictors, multiClassificationDatasets, extraTag: "keyU404");
@@ -506,11 +481,6 @@ public void MultiClassifierLightGBMKeyLabelU404Test()
         [TestCategory("LightGBM")]
         public void RegressorLightGBMTest()
         {
-            //Skip this test for macOS until engineering system installs OpenMP dependency for 
-            //native LightGBM library.
-            if (RuntimeInformation.IsOSPlatform(OSPlatform.OSX))
-                return;
-
             var regPredictors = new[] { TestLearners.LightGBMReg };
             var regDatasets = new[] { TestDatasets.winequality };
             RunAllTests(regPredictors, regDatasets);
@@ -525,11 +495,6 @@ public void RegressorLightGBMTest()
         [TestCategory("LightGBM")]
         public void RegressorLightGBMMAETest()
         {
-            //Skip this test for macOS until engineering system installs OpenMP dependency for 
-            //native LightGBM library.
-            if (RuntimeInformation.IsOSPlatform(OSPlatform.OSX))
-                return;
-
             var regPredictors = new[] { TestLearners.LightGBMRegMae };
             var regDatasets = new[] { TestDatasets.winequality };
             RunAllTests(regPredictors, regDatasets, extraTag: "MAE");
@@ -544,11 +509,6 @@ public void RegressorLightGBMMAETest()
         [TestCategory("LightGBM")]
         public void RegressorLightGBMRMSETest()
         {
-            //Skip this test for macOS until engineering system installs OpenMP dependency for 
-            //native LightGBM library.
-            if (RuntimeInformation.IsOSPlatform(OSPlatform.OSX))
-                return;
-
             var regPredictors = new[] { TestLearners.LightGBMRegRmse };
             var regDatasets = new[] { TestDatasets.winequality };
             RunAllTests(regPredictors, regDatasets, extraTag: "RMSE");