Initial Component catalog refactor #3
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Converted WordEmbeddingsTransform into Estimator. * Addressed reviewers' comments. * Added documentation for public API and addressed reviewers' comments. * Addressed reviewers' comments. * Addressed reviewers' comments. * Changed the estimator from trivial estimator to non-trivial estimator.
* moving FastTree derving classes to TrainerEstimatorBase * fixing the RankingScorer * Adding one test, defining the output columns. Changing the behavior for the creation of the weight column, based on whether it is explicit, or implicit. * Post merge fixes * arguments applied via the delegate adding test * Updated the test to use TestEstimatorCore, and fixed the null pointer on the MakeGroupId * using the new constructors in the codebase. Making use of dataset definitions adding Iris.data and the adult.tiny files to TestDatasets adding regression and ranking tests * adding the metadata * tweaking the test * resolving merge conflicts, and disabling the ranker test to check on the other tests. * Fixing the signature on the RankerPredictor Fixing the other two tests * Fixing regressions and tests * switching dataset * post merge fixes
eerhardt
force-pushed
the
ComponentCatalogRefactor
branch
from
5f4f5de
to
b2ed992
Compare
* added numeric ranking tests * feedback, indentation added * names change, url changes and warmcount changes * url corrected, https corrected and extra lines removed * tlc changed to console environment * https and closing brace added * Code block for MSLR-WEB10K/MSLR-WEB30K to format citation * Add missing semicolon. Missing semicolon is causing the build the fail.
… model (dotnet#862) * Add a method that returns TensorFlow model outputs as an ISchema. * Update after merge with master * Address PR comments. * Add metadata with information about the operation type, and the inputs needed for it. * Add method that returns an enumerable of the information about graph nodes, and a console app that displays it * Add the DnnAnalyzer project files. * Address code review comments * Make needed changes after merge with master * Fix bug when there is a node with 1 dimension that is unknown
* FAFM to extend TrainerEstimatorBase * Fixing the creation of getters on the Fafm predictor.
…lity * enabling scanning the constructors with non-public visibility, and reducing the visibility of some of them to avoid confusing the users.
Write the AssemblyName into the model, and use it to register the assembly during model load.
Also fix a couple more tests.
Ensure all loaded assemblies are registered in Experiment to maintain compability. Fix tests to not use ComponentCatalog but direct instantiation instead.
eerhardt
force-pushed
the
ComponentCatalogRefactor
branch
from
6210d67
to
a19a08e
Compare
eerhardt
pushed a commit
that referenced
this pull request
Oct 25, 2018
* Added placeholder * Cleaned up Infos (replaced with ColumnPairs) * Added ColumnInfo * Added all the Create() methods. * Added Mapper * Commented out the EntryPoint * Added PcaEstimator2 * PcaWorkout test passes * Added pigsty api * Fixed EntryPoint * Fixed the arguments * Fixed tests and added pigsty test * Deleted Wrapped PCA transform * Float -> float * Cleaned docstrings * Removed some unnecessary checks * Simplified unnecessary code * Moved some fields to ColumnInfo for simplifications * Simplified weight columns * Address PR comments #1 * Addressed PR comments #2 * Moved the static test * PR comments #3 * Moved schema related information out of ColumnInfo and into Mapper.ColumnSchemaInfo. * PR comments * PR comments * Updated manifest for entrypoint PcaCalculator * Fixed schema exceptions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See dotnet#208