-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
setComponentTemplate
is run twice on decorated classes
#16
Comments
ef4
added a commit
that referenced
this issue
Jan 16, 2024
This test demonstrates the failure from #16 I think the fix will go in `@embroider/shared-internals` but once it does this will tell us if we got it right.
ef4
added a commit
that referenced
this issue
Jan 16, 2024
This test demonstrates the failure from #16 I think the fix will go in `@embroider/shared-internals` but once it does this will tell us if we got it right.
ef4
added a commit
to embroider-build/embroider
that referenced
this issue
Jan 16, 2024
It's not possible to have more than one colocated template for a given JS file, so we never need to run again. Fixes ef4/decorator-transforms#16
I think this is fixed via embroider-build/embroider#1758 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Given an Ember component definition like this:
and a colocated template:
{{! components/my-component.hbs }} Hello world
The transpiled output looks something like this:
Note the duplicate calls to
setComponentTemplate
. This causes a runtime errorMinimal reproduction here: davidtaylorhq/decorator-transform-test@d01d5c4
Potential fix here: #18
The text was updated successfully, but these errors were encountered: