Remove dependency on node:module #27
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Should allow this package to be used in non-node environments. Resolves ef4#20
NullVoxPopuli
approved these changes
Apr 25, 2024
ef4
reviewed
Apr 26, 2024
| // @ts-expect-error no upstream types | ||
| import PluginSyntaxDecorators from "@babel/plugin-syntax-decorators"; | ||
| const decoratorSyntax = | ||
| PluginSyntaxDecorators.default || PluginSyntaxDecorators; |
There was a problem hiding this comment.
I am loathe to spread this kind of incorrect code further through the ecosystem.
I think this is a bug in tsup: egoist/tsup#1078
We don't need to use tsup, I'm fine with using babel or tsc directly instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should allow this package to be used in non-node environments. Resolves #20