Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix syntax error in gpio_control_block #60

Merged
merged 2 commits into from
Apr 9, 2022
Merged

Conversation

marwaneltoukhy
Copy link
Member

Fixed syntax error that was only visible when running iverilog for simulation

Fixed syntax error that was only visible when running iverilog for simulation
Copy link
Contributor

@RTimothyEdwards RTimothyEdwards left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The verilog language could be greatly improved by not making it a syntax error to have a comma after the last entry. Same for JSON, YAML, and various other file formats.

@kareefardi
Copy link
Contributor

The verilog language could be greatly improved by not making it a syntax error to have a comma after the last entry. Same for JSON, YAML, and various other file formats.

The thing is openlane didn't fail with this. So it might be something specific with iverilog. I need to double check.

@jeffdi jeffdi merged commit 14142eb into main Apr 9, 2022
@marwaneltoukhy marwaneltoukhy deleted the gpio_control_block_fix branch April 11, 2022 16:12
M0stafaRady pushed a commit that referenced this pull request Sep 30, 2022
* Fix syntax error in gpio_control_block

Fixed syntax error that was only visible when running iverilog for simulation

* Apply automatic changes to Manifest and README.rst

Co-authored-by: marwaneltoukhy <marwaneltoukhy@users.noreply.github.com>
@RTimothyEdwards RTimothyEdwards added error Something isn't working RTL Verilog source code changed labels Oct 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
error Something isn't working RTL Verilog source code changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants