Changes that correct mgmt_core references and user_id_programming generation. #73
Conversation
Initial steps for LVS and CVC-RV for MPW-4 slot-002
diode and short errors
`simple_por` changes to `caravel.v`
…t_core references. mgmt_core_wrapper Use absolute path instead of relative path. user_id_programming Remove GDS references as GDS is no longer modified. Corrected string concatenation. Corrected mag data replacement. Corrected verilog data replacement. gpio_default_block Rename instances for gpio_default_blocks 0-4 in caravel.mag and caravan.mag. Change replace range in gen_gpio_defaults.py to handle gpio_default_blocks 0-4.
|
I'll revert the |
d-m-bailey
changed the title
|
Thanks. I made a quick pass over the rest and they look good, but I'm doing a few fixes to Caravan and I'll try to get your pull request reviewed and queued up for a merge next. |
There was a problem hiding this comment.
Makefile lines 125 and 177: I agree that the path should not be relative, which makes it depend on the management core wrapper being cloned into or linked from caravel, but it should be $(MCW_ROOT), which is the path to the management core wrapper repository, not $(UPRJ_ROOT), which is the user project repository.
|
@d-m-bailey : If you can make that one correction, I can go ahead and approve this for a merge, because there are no conflicts with the pull request I'm currently working on. |
|
@jeffdi : Please merge this pull request. |
|
@RTimothyEdwards Changed There's also an (apparently) unused |
|
@jeffdi @RTimothyEdwards Can you wait on this? It's not only moving the licon, but also the met1 and via at the same locations!
|
|
@jeffdi : Mitch is right; the original reason for using the GDS was that it was a bit simpler to alter the contacts, since in magic the contact can't just be moved; it has to be replaced by the overlapping metals or else it will leave empty space behind. @d-m-bailey : I understand the issue and I just need to make a modification to the .mag file to ensure that there is redundant metal over the area of the via in the file so that when the via is moved, the metal will remain. I suggest that @jeffdi go ahead and merge the pull request anyway, and I will fix the .mag file early tomorrow. |
|
done.
…-- Jeff
On Mon, Apr 18, 2022 at 8:15 PM R. Timothy Edwards ***@***.***> wrote:
@jeffdi <https://github.com/jeffdi> : Mitch is right; the original reason
for using the GDS was that it was a bit simpler to alter the contacts,
since in magic the contact can't just be moved; it has to be replaced by
the overlapping metals or else it will leave empty space behind.
@d-m-bailey <https://github.com/d-m-bailey> : I understand the issue and
I just need to make a modification to the .mag file to ensure that there is
redundant metal over the area of the via in the file so that when the via
is moved, the metal will remain. I suggest that @jeffdi
<https://github.com/jeffdi> go ahead and merge the pull request anyway,
and I will fix the .mag file early tomorrow.
—
Reply to this email directly, view it on GitHub
<#73 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AKAZZ5JXS4OCNQ3DVVEP5BTVFYQN3ANCNFSM5TVLXVLA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
@RTimothyEdwards Currently, |
|
@RTimothyEdwards Looks like the global replace of coordinates moved |
successfully, and if merged now they will generate conflicts with this pull request in scripts/set_user_id.py. So it's easier to just manually add them to this pull request.
…avan. (#76) * (1) Modified the .magicrc file to set a default for PDK if not set in the environment. (2) Fixed the user ID programming layout to not leave holes behind when the script moves the vias around (similar to the handling of the GPIO defaults block). (3) Added substrate isolation to gpio_control_block and fixed the path references to the standard cells. (4) Fixed the four missing routes on the Caravan top level. (5) Reinstated the large rendered labels for the pads on both caravel and caravan. (6) Corrected the top level gate-level netlist for caravan to add the missing pins to the management core wrapper. (7) Did the same for the caravan top level RTL. (8) Created scripts to run full LVS including extracting the management core wrapper and reading all gate-level verilog submodules. (9) Moved all of the LVS scripts to the scripts directory. * Apply automatic changes to Manifest and README.rst * Made the changes from pull request #73 as they did not get merged successfully, and if merged now they will generate conflicts with this pull request in scripts/set_user_id.py. So it's easier to just manually add them to this pull request. * Apply automatic changes to Manifest and README.rst Co-authored-by: RTimothyEdwards <RTimothyEdwards@users.noreply.github.com>
…eration. (#73) * Create lvs-cvc.rst * user_project_analog_wrapper -> user_analog_project_wrapper * Added table * Update lvs-cvc.rst * Create lvs_cvc_mpw4.rst Initial steps for LVS and CVC-RV for MPW-4 slot-002 * Update lvs_cvc_mpw4.rst diode and short errors * daily progress `simple_por` changes to `caravel.v` * Update lvs_cvc_mpw4.rst * Remove old local documentation. * Changes that correct gpio_default_block, user_id_programming, and mgmt_core references. mgmt_core_wrapper Use absolute path instead of relative path. user_id_programming Remove GDS references as GDS is no longer modified. Corrected string concatenation. Corrected mag data replacement. Corrected verilog data replacement. gpio_default_block Rename instances for gpio_default_blocks 0-4 in caravel.mag and caravan.mag. Change replace range in gen_gpio_defaults.py to handle gpio_default_blocks 0-4. * Revert changes related to gpio_default_block. * Changed mgmt_core_wrapper absolute path from UPRJ_ROOT to MCW_ROOT. * Corrected MCW_ROOT path (includes mgmt_core_wrapper)
…avan. (#76) * (1) Modified the .magicrc file to set a default for PDK if not set in the environment. (2) Fixed the user ID programming layout to not leave holes behind when the script moves the vias around (similar to the handling of the GPIO defaults block). (3) Added substrate isolation to gpio_control_block and fixed the path references to the standard cells. (4) Fixed the four missing routes on the Caravan top level. (5) Reinstated the large rendered labels for the pads on both caravel and caravan. (6) Corrected the top level gate-level netlist for caravan to add the missing pins to the management core wrapper. (7) Did the same for the caravan top level RTL. (8) Created scripts to run full LVS including extracting the management core wrapper and reading all gate-level verilog submodules. (9) Moved all of the LVS scripts to the scripts directory. * Apply automatic changes to Manifest and README.rst * Made the changes from pull request #73 as they did not get merged successfully, and if merged now they will generate conflicts with this pull request in scripts/set_user_id.py. So it's easier to just manually add them to this pull request. * Apply automatic changes to Manifest and README.rst Co-authored-by: RTimothyEdwards <RTimothyEdwards@users.noreply.github.com>
RTimothyEdwards
added
error
mgmt_core_wrapper: fixes #71
user_id_programming: fixes #70
gpio_default_block: fixes #72~Change replace range in gen_gpio_defaults.py to handle gpio_default_blocks 0-4.