Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changed int (truncate) to round to correct gpio_default error. #83

Merged
merged 1 commit into from
Apr 22, 2022
Merged

Changed int (truncate) to round to correct gpio_default error. #83

merged 1 commit into from
Apr 22, 2022

Conversation

d-m-bailey
Copy link
Contributor

Fixes #82

RTimothyEdwards
RTimothyEdwards approved these changes Apr 22, 2022
View reviewed changes
Copy link
Contributor

@RTimothyEdwards RTimothyEdwards left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I never even knew this was a problem. Thanks for catching it.

@RTimothyEdwards
Copy link
Contributor

@jeffdi : Please merge this pull request. Without it, the GPIO defaults may appear to have been handled correctly, but occasional bits may be wrong because the round-off error means that the script won't find a via at the expected position, won't move the via because it didn't see it, and so that bit will be wrong.

@jeffdi jeffdi merged commit da3f77d into efabless:main Apr 22, 2022
@d-m-bailey
Copy link
Contributor Author

d-m-bailey commented Apr 23, 2022 •
edited
Loading

@RTimothyEdwards @jeffdi
WARNING: This script creates new correct gpio_defaults_blocks only if they don't exist.
If there are previous incorrect gpio_default_blocks in the caravel_user_project/mag directory, they will NOT be overwritten!

antonblanchard pushed a commit to antonblanchard/caravel that referenced this pull request Apr 27, 2022
@jeffdi
Merge pull request efabless#83 from efabless/litex_integration_GL
9576383 
GL simulation tb updates
M0stafaRady pushed a commit that referenced this pull request Sep 30, 2022
@d-m-bailey
Changed int (truncate) to round to correct gpio_default error. (#83)
7785cc1
@RTimothyEdwards RTimothyEdwards added error Something isn't working flow Makefile or in-repository flow script changed labels Oct 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RTimothyEdwards RTimothyEdwards RTimothyEdwards approved these changes

Assignees
No one assigned
Labels
error Something isn't working flow Makefile or in-repository flow script changed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

gpio_default_block does not have gpio_default[3] set to high.
3 participants
@d-m-bailey @RTimothyEdwards @jeffdi