Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Makefile to pip caravel-cocotb #307

Merged
merged 7 commits into from
Sep 24, 2023
Merged

Conversation

M0stafaRady
Copy link
Member

@M0stafaRady M0stafaRady commented Sep 20, 2023

new version of caravel-cocotb script. It should fix #303.

Please delete the branch after merge.

Copy link
Member

@marwaneltoukhy marwaneltoukhy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add the installation and running inside venv?

Copy link
Member

@marwaneltoukhy marwaneltoukhy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like you updated the target names, can you update it in the documentation as well? (make sure that you're updating the correct documentation). Also the name of the test from counter_tests/counter_tests.yaml to user_proj_tests/user_proj_tests.yaml, so you need to update the name of the files.

@M0stafaRady M0stafaRady changed the title Update Makefile to pip caravel-cocotb-1.1.1 Update Makefile to pip caravel-cocotb Sep 20, 2023
@marwaneltoukhy
Copy link
Member

I get this error

caravel_cocotb -tl user_proj_tests/user_proj_tests.yaml
Run tag: run_21_Sep_10_38_56_85 
Start running test:  RTL-counter_la 
     -.--ns INFO     gpi                                ..mbed/gpi_embed.cpp:76   in set_program_name_in_venv        Did not detect Python virtual environment. Using system-wide Python interpreter
     -.--ns INFO     gpi                                ../gpi/GpiCommon.cpp:101  in gpi_print_registered_impl       VPI registered
/home/marwan/user_project/verilog/dv/cocotb/sim/run_21_Sep_10_38_56_85/RTL-compilation/sim.vvp: Unable to open input file.
Error: Fail to compile the verilog code for more info refer to /home/marwan/user_project/verilog/dv/cocotb/sim/run_21_Sep_10_38_56_85/RTL-compilation/compilation.log
Start running test:  RTL-counter_wb 
     -.--ns INFO     gpi                                ..mbed/gpi_embed.cpp:76   in set_program_name_in_venv        Did not detect Python virtual environment. Using system-wide Python interpreter
     -.--ns INFO     gpi                                ../gpi/GpiCommon.cpp:101  in gpi_print_registered_impl       VPI registered
/home/marwan/user_project/verilog/dv/cocotb/sim/run_21_Sep_10_38_56_85/RTL-compilation/sim.vvp: Unable to open input file.
Error: Fail to compile the verilog code for more info refer to /home/marwan/user_project/verilog/dv/cocotb/sim/run_21_Sep_10_38_56_85/RTL-compilation/compilation.log
Start running test:  RTL-counter_la_reset 
     -.--ns INFO     gpi                                ..mbed/gpi_embed.cpp:76   in set_program_name_in_venv        Did not detect Python virtual environment. Using system-wide Python interpreter
     -.--ns INFO     gpi                                ../gpi/GpiCommon.cpp:101  in gpi_print_registered_impl       VPI registered
/home/marwan/user_project/verilog/dv/cocotb/sim/run_21_Sep_10_38_56_85/RTL-compilation/sim.vvp: Unable to open input file.
Error: Fail to compile the verilog code for more info refer to /home/marwan/user_project/verilog/dv/cocotb/sim/run_21_Sep_10_38_56_85/RTL-compilation/compilation.log
Start running test:  RTL-counter_la_clk 
     -.--ns INFO     gpi                                ..mbed/gpi_embed.cpp:76   in set_program_name_in_venv        Did not detect Python virtual environment. Using system-wide Python interpreter
     -.--ns INFO     gpi                                ../gpi/GpiCommon.cpp:101  in gpi_print_registered_impl       VPI registered
/home/marwan/user_project/verilog/dv/cocotb/sim/run_21_Sep_10_38_56_85/RTL-compilation/sim.vvp: Unable to open input file.
Error: Fail to compile the verilog code for more info refer to /home/marwan/user_project/verilog/dv/cocotb/sim/run_21_Sep_10_38_56_85/RTL-compilation/compilation.log

I attached the compilation log, it has errors in the include.
compilation.log

@M0stafaRady
Copy link
Member Author

I'm aware of this error.
This pull request should solve it: efabless/caravel#488

@marwaneltoukhy marwaneltoukhy linked an issue Sep 21, 2023 that may be closed by this pull request
verilog/dv/cocotb/design_info.yaml Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
M0stafaRady and others added 3 commits September 24, 2023 11:31
remove display info from make file

Co-authored-by: Marwan Abbas <67271180+marwaneltoukhy@users.noreply.github.com>
Rename cocotb virtual env

Co-authored-by: Marwan Abbas <67271180+marwaneltoukhy@users.noreply.github.com>
@jeffdi jeffdi merged commit c913b37 into main Sep 24, 2023
6 checks passed
@jeffdi jeffdi deleted the update_caravel_cocotb_ver branch September 24, 2023 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

make setup error - module named click missing make setup fails with latest commit
3 participants