Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove default_nettype statements at the end of the RTL #366

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kareefardi
Copy link
Contributor

@kareefardi kareefardi commented Jun 26, 2024

Surfaced by The-OpenROAD-Project/OpenLane#2083. Yosys would use the default nettype wire when compiling the user project. Although this might be an ambiguity in yosys behavior, I don't see the need of adding these lines. Having said that, there presence in the RTL seems to be intentional, I added @marwaneltoukhy and @M0stafaRady as reviewers to asses if this PR is going to have any further impact.

Signed-off-by: Kareem Farid <kareefardi@users.noreply.github.com>
@M0stafaRady
Copy link
Member

I'm not sure if it a standard this but I recall to notice on compiler was dealing with the `default_nettype as a global macro not just for the current file. So if we removed the line in the end of the file, the next to be compiled will be treated as if the default net type is none. So, I don't recommend it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants