Proper "Fetch" Mode #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Created `GitHubSession` based on work from IPM - no longer global, created by `click` in the CLI and passed around to function * Created new function `fetch()` based on was what previously `get()` (now deprecated), accessible over the CLI using `volare fetch`, which download versions and/or SCLs without affecting the top-level PDK root * Changed `get_current_version`, `get_installed_list`, `get_version_dir` and `root_for` to print deprecation warnings * Consolidated SCL list processing in `Family`-- `Family.resolve_libraries()` takes an iterable list of inputs and returns the set of target SCLs, expanding `default` into the default set and `all` into all SCLs as appropriate * **API Break**: Most arguments that aren't `pdk_root`, `pdk`, `version` are now keyword-only arguments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHubSessionbased on work from IPM - no longer global, created byclickin the CLI and passed around to functionfetch()based on was what previouslyget()(now deprecated), accessible over the CLI usingvolare fetch, which download versions and/or SCLs without affecting the top-level PDK rootget_current_version,get_installed_list,get_version_dirandroot_forto print deprecation warningsFamily--Family.resolve_libraries()takes an iterable list of inputs and returns the set of target SCLs, expandingdefaultinto the default set andallinto all SCLs as appropriatepdk_root,pdk,versionare now keyword-only arguments