refactor: drop isTruthy; use Predicate module

effect-ts-app · Dec 7, 2023 · 169ccb0 · 169ccb0
1 parent 1963df6
commit 169ccb0
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 3 deletions.
diff --git a/.changeset/chatty-tomatoes-taste.md b/.changeset/chatty-tomatoes-taste.md
@@ -0,0 +1,6 @@
+---
+"@effect-app/infra-adapters": minor
+"@effect-app/core": minor
+---
+
+drop isTruthy; use Predicate module
diff --git a/packages/core/_src/utils.ts b/packages/core/_src/utils.ts
@@ -27,7 +27,6 @@ export function toString(v: unknown) {
   return `${v}`
 }
 
-export const isTruthy = <T>(item: T | null | undefined): item is T => Boolean(item)
 export const typedKeysOf = <T extends {}>(obj: T) => Object.keys(obj) as (keyof T)[]
 // eslint-disable-next-line @typescript-eslint/no-unnecessary-type-assertion
 export const typedValuesOf = <T extends {}>(obj: T) => Object.values(obj) as ValueOf<T>[]

diff --git a/packages/infra-adapters/_src/CUPS/live.ts b/packages/infra-adapters/_src/CUPS/live.ts
@@ -2,7 +2,7 @@ import cp from "child_process"
 import util from "util"
 import { tempFile } from "../fileUtil.js"
 
-import { isTruthy, pretty } from "@effect-app/core/utils"
+import { pretty } from "@effect-app/core/utils"
 import { NonEmptyString255 } from "@effect-app/schema"
 import fs from "fs"
 import os from "os"
@@ -92,7 +92,7 @@ function getAvailablePrinters(host?: string) {
     const { stdout } = $(exec(["lpstat", ...buildListArgs({ host }), "-s"].join(" ")))
     return [...stdout.matchAll(/device for (\w+):/g)]
       .map((_) => _[1])
-      .filter(isTruthy)
+      .filter(Predicate.isNotNullable)
       .map(NonEmptyString255)
   })
 }