Feature/init array default values #296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IR0NSIGHT
force-pushed
the
feature/init-array-default-values
branch
2 times, most recently
from
e2821cb to
f1496e0
Compare
IR0NSIGHT
force-pushed
the
feature/init-array-default-values
branch
from
f1496e0 to
004fb02
Compare
IR0NSIGHT
force-pushed
the
feature/init-array-default-values
branch
from
adab236 to
8663d57
Compare
|
@phischu done |
phischu
reviewed
Nov 8, 2023
phischu
approved these changes
Nov 10, 2023
b-studios
reviewed
Nov 10, 2023
| def worker[T](list: List[T], i: Int){ f: (Int, T) => Unit}: Unit = { | ||
| list match { | ||
| case Nil() => (); | ||
| case Cons(head, tail) => f(i, head); worker(tail, i+1){f} |
There was a problem hiding this comment.
@IR0NSIGHT @phischu f is stable throughout the recursion, please consider dropping it from worker.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
allows initializing a mutable array of size n with default values
skips having to init an array of size n with unknown type values and then having to fill the array with values.
added some QOL features such as init array from a function by index and init array from hardcoded list
fixes #291