Feature/multiple return values invariants #312
Conversation
| @@ -108,7 +108,7 @@ class Repl(driver: Driver) extends REPL[Tree, EffektConfig, EffektError] { | |||
| runFrontend(StringSource(""), module.make(UnitLit()), config) { cu => | |||
| module.definitions.foreach { | |||
| case u: Def => | |||
| outputCode(DeclPrinter(context.symbolsOf(u)), config) | |||
| outputCode(DeclPrinter(List(u.id.symbol)), config) | |||
There was a problem hiding this comment.
This is confusing to me, doesn't u.id.symbol already sometimes return a list?
| case Some(b: BlockSymbol) => | ||
| Some(context.blockTypeOf(b)) | ||
| Some(b, context.blockTypeOf(b)) | ||
| case t => |
There was a problem hiding this comment.
As said before, did you check this works with the REPL? I would guess it does not print anything. Also it should probably be foreach and not map.
There was a problem hiding this comment.
Prints nothing in the repl because d.id is empty. In case of ValDef we need d.binders.map(_.id)
There was a problem hiding this comment.
You could in principle match on d and special case if it is a ValDef.
| (ids zip tpes) foreach { (id, tpe) => | ||
| Context.define(id, ValBinder(Context.nameFor(id), tpe, d)) | ||
| binders.foreach { case source.ValueParam(id, tpe) => | ||
| Context.define(id, ValBinder(Name.local(id), tpe.map(resolve), d)) |
There was a problem hiding this comment.
Is this change from nameFor to local intentional?
| idDef ~ (`:` ~/> valueType).? ^^ { case id ~ tpe => (id, tpe)} | ||
| lazy val valDef: P[Def] = | ||
| `val` ~> someSep(valueParamOpt, `,`) ~ (`=` ~/> stmt) ^^ { | ||
| case binders ~ binding => ValDef(binders, binding) |
|
|
||
| def symbolsOf(tree: source.Definition): List[Symbol] = | ||
| tree.ids.map(symbolOf) | ||
|
|
There was a problem hiding this comment.
Did you check where this was used in master?
There was a problem hiding this comment.
This function was written by me to get the list of symbols. It was only used in a few places.
|
/cc @denhie this is important for you |
|
Thanks for merging, but please let us answer the questions, still |
No description provided.