-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix some memory leaks #736
base: master
Are you sure you want to change the base?
Conversation
No, the other leaking tests are not fixed by this entirely. My additional pos erasers in the stdlib make Valgrind even angrier. |
Could you please add your additional pos erasers in the stdlib to this pull request? |
I've added them. I'm still not 100% sure when we are supposed to add erasers and whether my additions are correct. We should really start writing a detailed sharer/eraser guide :) |
27cf964
to
c752e08
Compare
Thank you. I have applied some fixes, please check if we can enable more tests for llvm now. |
c752e08
to
87ab60d
Compare
This seems to improve things by a lot! There are still some tests left that fail with segfaults (use-after-free most probably) in UV/IO code, as well as some IO/bytearray-related code in stdlib. I've pushed the uncommented tests to see some immediate CI response on further fixes. |
Does this fix the leak in #711? |
|
dc20bb9
to
e1ddadc
Compare
862de57
to
efa2512
Compare
@marvinborner With these fixes the following does not leak anymore:
Does this also fix other tests that are commented out?