Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add 'show' for 'Byte' on JavaScript #752

Merged
merged 1 commit into from
Dec 21, 2024
Merged

Add 'show' for 'Byte' on JavaScript #752

merged 1 commit into from
Dec 21, 2024

Conversation

CanCodes
Copy link
Contributor

Fixes #749

@CanCodes CanCodes marked this pull request as draft December 19, 2024 12:04
@jiribenes jiribenes marked this pull request as ready for review December 21, 2024 11:52
@jiribenes jiribenes changed the title Add JavaScript Implementation for show Function on Byte Data Type Add 'show' for 'Byte' on JavaScript Dec 21, 2024
jiribenes
jiribenes approved these changes Dec 21, 2024
View reviewed changes
Copy link
Contributor

@jiribenes jiribenes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@jiribenes jiribenes merged commit 9007b05 into effekt-lang:master Dec 21, 2024
2 checks passed
b-studios pushed a commit that referenced this pull request Dec 24, 2024
@CanCodes @b-studios
Add 'show' for 'Byte' on JavaScript (#752)
4394f41 
Fixes #749
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jiribenes jiribenes jiribenes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing JavaScript Implementation for show Function on Byte Data Type
2 participants
@CanCodes @jiribenes