feat: implement multiple named conversations #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bytesoverflow
commented
Nov 6, 2024
bytesoverflow
commented
- Replace single conversation file with a conversations directory structure
- Add support for named conversations via -n/--name flag
- Implement conversation name validation
- Add test coverage for conversation management
|
So, this is my attempt! Critique welcome :) |
bytesoverflow
force-pushed
the
named-conversations
branch
from
a50cc3c to
dd5de60
Compare
efugier
reviewed
Nov 6, 2024
bytesoverflow
force-pushed
the
named-conversations
branch
from
4b4deca to
1e27688
Compare
- Replace single conversation file with a conversations directory structure - Add support for named conversations via -n/--name flag - Implement conversation name validation - Add test coverage for conversation management
- Use conversation.toml for storing latest conversation state - Remove unnecessary directory creation in config initialization - Update test coverage
bytesoverflow
force-pushed
the
named-conversations
branch
from
1e27688 to
9f91859
Compare
efugier
reviewed
Nov 10, 2024
There was a problem hiding this comment.
Hey, good stuff!
After some testing this works nicely you really did a good job!
I am questioning the final API, maybe there should be a shorthand -e "name" instead of -e -n "name" which kinda feels redundant, and -e "name maybe should create the new conversation if it doesn't exist, then we actually lose the need for the -n except for overriding an existing one.
Let me warp my head about what would feel the most natural or use! Happy to hear your thoughts on the matter in the meantime 🙂
|
Thank you, I agree the API feels odd - I think what you're suggesting would be an improvement. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.